refactor: remove pinixd built-in scheduler - #167
Merged
Conversation
The cloud agent scheduler (agent_schedules table + API goroutine) has fully replaced this. Remove: - internal/daemon/scheduler.go (cron runtime + invoke) - internal/daemon/scheduler_clip.go (builtin clip adapter) - internal/daemon/scheduler_store.go (SQLite execution history) - internal/builtin/scheduler.go (SchedulerInvoker interface + NewSchedulerClip) - cmd/pinix/schedule.go (CLI schedule subcommands) Also remove from daemon.go: scheduler field, SetScheduler(), GetScheduler(), scheduler.Stop() in Close(), and the SetOnClipAdded callback that auto-registered clip-declared schedules. Data structures (ManifestScheduleDecl, ScheduleConfig in registry, proto schedule fields) are preserved — they define the declaration format, not the runtime. Closes #166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_schedulestable + API goroutine in pinix.ai)schedulerfield,SetScheduler(),GetScheduler(), scheduler stop inClose()ManifestScheduleDecl,ScheduleConfig, proto fields) — they define the declaration format, not the runtimeCloses #166