feat(proto): add description field to ClipInfo and ClipRegistration - #116
Open
yan5xu wants to merge 2 commits into
Open
feat(proto): add description field to ClipInfo and ClipRegistration#116yan5xu wants to merge 2 commits into
yan5xu wants to merge 2 commits into
Conversation
Large ClipWeb files (>256KB) are now sent in 256KB chunks, releasing the send mutex between each chunk so heartbeat pings can get through. This prevents session expiry when transferring large files over slow connections. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Proto: ClipInfo.description (field 12), ClipRegistration.description (field 12) - clipToClipInfo: set Description from manifest - localClipToRegistration: include Description in provider registration - sanitizeProviderClip: pass through Description - providerClipToManifest: pass through Description - providerClipToClipInfo: set Description Closes #115 (partial — Console Web data layer)
yan5xu
force-pushed
the
feat/clipweb-chunk
branch
from
June 2, 2026 10:48
9e833ee to
1485169
Compare
yan5xu
force-pushed
the
feat/clipweb-chunk
branch
from
June 2, 2026 11:12
1485169 to
07e3655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
description(field 12) to bothClipInfoandClipRegistrationproto messages.All code paths updated to pass description through:
clipToClipInfo: sets Description from manifestlocalClipToRegistration: includes Description in provider registrationsanitizeProviderClip: passes through DescriptionproviderClipToManifest: passes through DescriptionproviderClipToClipInfo: sets DescriptionPart of Console Web (#115).