fix(open): preserve returned tab ids - #213
Closed
MonkeyLeeT wants to merge 1 commit into
Closed
Conversation
MonkeyLeeT
marked this pull request as ready for review
May 11, 2026 06:17
MonkeyLeeT
force-pushed
the
codex/fix-open-tab-targeting
branch
from
May 11, 2026 17:42
34d0b11 to
1d0ecbc
Compare
MonkeyLeeT
force-pushed
the
codex/fix-open-tab-targeting
branch
5 times, most recently
from
May 28, 2026 17:35
3fadeda to
40b5ebd
Compare
MonkeyLeeT
force-pushed
the
codex/fix-open-tab-targeting
branch
from
May 29, 2026 15:54
40b5ebd to
9cecb05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bb-browser open --tab, including short ids, full CDP target ids, and numeric-looking short idsopen --tab currentnavigate the active/current daemon target instead of resolvingcurrentas a literal tab idtabid in humanopenoutput while still showing the full target id separatelyopenids in a follow-upevalrequestScope
This PR keeps the
openlifecycle behavior unchanged: new tabs are still created in the background andopendoes not wait for page readiness. It only fixes the tab id contract so returned ids and explicit--tabvalues stay usable by the daemon resolver.Root cause
The CLI parsed
open --tabas a number, which rejected full CDP target ids and could turn numeric-looking short ids into tab indexes. The daemon also treatedcurrentas an ordinary tab reference before the open handler had a chance to navigate the current tab.Validation
openlifecycle changesRefs #195