Update reference screens to use new record names#80
Merged
Conversation
Contributor
|
Thanks for creating this, I will take a look! |
Contributor
Author
|
It's not super urgent, but I thought it's something I could contribute. By the way, I wonder if we should also remove the edl screens from P.S.: I had accidentally run my script twice, so the records that only got appended (i.e., |
|
LGTM. |
Contributor
|
LGTM as well. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello fellow EPICS engineers,
This PR updates the reference screens to follow the new standard implemented in release 4.0.0. The new standard uses the actual environment variable names (as defined in CONFIG_ENV and CONFIG_SITE_ENV) for the record names. Although most of these screens continue to work due to the compatibility aliases (with the exception of EPICS_TIMEZONE, more on that on the second paragraph), this PR updates the names so the screens follow the new standard and will continue to work after the compatibility aliases are removed from the inclusion by default.
The EPICS_TIMEZONE env var was deprecated with the release of EPICS 3.15.7 (back in 2019). Nevertheless, it wasn't until this commit (8715ab4) in 2023 that the EPICS_TIMEZONE record was removed from the generated db files (and replaced by the EPICS_TZ variable). In the meantime (for those using the latest EPICS and iocStats versions), the record continued to exist, but was not functional. My understanding is that other than for vxWorks, this variable doesn't do much, which is probably why this went unnoticed until now.
P.S.: I don't have access to some of these tools, so I could not test all of them, I simply replaced the record names in those. I believe there shouldn't be any issues from that, but caveat emptor.
P.S.: Also, since screens continue to (for most intents and purposes) work fine, I didn't think this deserved to have an issue in addition to the PR. But if it'd be best to have an issue for internal tracking/changelog purposes, I would be glad to file it as well.