feat: redeem offline credentials for DIAL_NATIVE services and report honest status - #1821
Merged
Merged
Conversation
DmytroZaichenkoDev
requested review from
Oleksii-Klimov and
astsiapanay
as code owners
August 11, 2026 10:44
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-redemption
branch
from
August 11, 2026 10:50
77176fd to
d1e67e5
Compare
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-redemption
branch
from
August 11, 2026 13:38
d1e67e5 to
203d0d1
Compare
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-redemption
branch
from
August 11, 2026 14:44
203d0d1 to
10bb976
Compare
This comment has been minimized.
This comment has been minimized.
astsiapanay
previously approved these changes
Aug 12, 2026
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-redemption
branch
from
August 12, 2026 12:18
10bb976 to
f87dbff
Compare
This comment has been minimized.
This comment has been minimized.
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-redemption
branch
from
August 12, 2026 13:00
f87dbff to
662e7fe
Compare
This comment has been minimized.
This comment has been minimized.
astsiapanay
approved these changes
Aug 12, 2026
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-redemption
branch
from
August 12, 2026 13:16
662e7fe to
bfb37e3
Compare
…honest status Wires DIAL_NATIVE into the on-behalf-of retrieval: redemption requires an administrator's consent record (only a record the consent endpoint wrote counts — never a leftover credential), then acts through the owner's platform-wide offline credentials, refreshed via the offline client of the identity provider that issued them. Failures stay distinguishable: missing or rejected owner credentials are a permanent 409 until the owner reconnects, an unreachable identity provider is a retryable 502, and a lost provider configuration is a 503. Status reporting becomes honest for DIAL-native services: app level reflects the admin's consent and user level reflects the caller's offline credentials, memoized per response by ExternalServiceStatusEnricher across the deployment, application and external-service listings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-redemption
branch
from
August 12, 2026 13:24
bfb37e3 to
e23daa0
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4/4 of the offline-delegation split (replaces #1815). Based on #1820.
Wires
DIAL_NATIVEinto on-behalf-of retrieval: redemption requires an administrator's consent record (only one the consent endpoint wrote counts), then acts through the owner's offline credentials, refreshed via the offline client of the issuing identity provider. Failures stay distinguishable: missing/rejected owner credentials → permanent 409, unreachable IdP → retryable 502, lost provider config → 503. Status becomes honest for DIAL-native services: app level reflects consent, user level reflects the caller's offline credentials (ExternalServiceStatusEnricher).The final state of this stack matches #1815 (verified e2e on Keycloak and Entra ID) except for review-driven cleanups made during the split.
🤖 Generated with Claude Code