Skip to content

feat: wrap watch.namespaces helm template check in a with block#9067

Open
cnvergence wants to merge 2 commits into
envoyproxy:mainfrom
cnvergence:fix-helm-errors
Open

feat: wrap watch.namespaces helm template check in a with block#9067
cnvergence wants to merge 2 commits into
envoyproxy:mainfrom
cnvergence:fix-helm-errors

Conversation

@cnvergence
Copy link
Copy Markdown
Member

@cnvergence cnvergence commented May 22, 2026

What type of PR is this?

What this PR does / why we need it:
Wrapping the check in a with block as suggested in the issue #9064

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 481d9a0
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a157637054e53000887538f
😎 Deploy Preview https://deploy-preview-9067--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.82%. Comparing base (42eba71) to head (481d9a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9067      +/-   ##
==========================================
+ Coverage   74.76%   74.82%   +0.05%     
==========================================
  Files         252      252              
  Lines       40571    40571              
==========================================
+ Hits        30333    30357      +24     
+ Misses       8167     8145      -22     
+ Partials     2071     2069       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cnvergence cnvergence changed the title wrap watch.namespaces helm template check in a with block feat: wrap watch.namespaces helm template check in a with block May 25, 2026
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence marked this pull request as ready for review May 26, 2026 10:30
@cnvergence cnvergence requested a review from a team as a code owner May 26, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant