feat: wrap watch.namespaces helm template check in a with block#9067
Open
cnvergence wants to merge 2 commits into
Open
feat: wrap watch.namespaces helm template check in a with block#9067cnvergence wants to merge 2 commits into
cnvergence wants to merge 2 commits into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9067 +/- ##
==========================================
+ Coverage 74.76% 74.82% +0.05%
==========================================
Files 252 252
Lines 40571 40571
==========================================
+ Hits 30333 30357 +24
+ Misses 8167 8145 -22
+ Partials 2071 2069 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
5b3e90e to
481d9a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Wrapping the check in a with block as suggested in the issue #9064
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No