-
Notifications
You must be signed in to change notification settings - Fork 54
Refactor event registration to allow multiple handlers per event #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8254001
Allow multiple onEvent registrations per event
claude 0f0a8e3
Don't drop where-empty registrations at finish
claude 021b096
Store chain-independent registration intents; fix review findings
claude e954219
Validate where at call site; drop composition-era test fixtures
claude 089b24a
Say "dispatch key" not "signature" in duplicate-event error
claude 6dde622
Validate intent `where` across all matching chains
claude 3932d7e
Capture raw events for where:false events; dedupe raw events per log
claude eeb6080
Exclude where:false events from raw events; keep handler-less backfill
claude 33de8ce
Simplify duplicate-event message; move dup tests to ReScript
claude bacd334
Resolve onEvent `where` once per chain; add dispatch-order test
claude bcf9df7
Add MultiHandlerOrder to Indexer_test expected ABI
claude 483ddad
Resolve registrations at onEvent into one reused registration
claude 6b558bc
Merge branch 'main' into claude/multiple-event-registrations-4lpfgw
DZakh 1f5d6b4
Match exact duplicate-event error messages after base merge
claude bfcaeeb
Eliminate worker thread from TestIndexer, store entities decoded (#1476)
DZakh 9361917
Merge branch 'main' into claude/multiple-event-registrations-4lpfgw
DZakh 49ff3e9
Merge remote-tracking branch 'origin/main' into claude/multiple-event…
claude ea3e7af
Point merged tests at InternalTestIndexer.fromUserApi
claude 9b90e52
Pin Noop.EmptyEvent handler to chain 1; drop MultiHandlerOrder fixture
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 0 additions & 54 deletions
54
packages/envio-tests/test/HandlerRegisterValidation_test.res
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When two SVM instructions use the same discriminator bytes with different hex casing, such as
0x0fand0x0F, this string key treats them as distinct and parsing accepts both. The SVM router decodes discriminator strings to bytes before matching, so a matching instruction then fans out to both indistinguishable registrations even though this parser check is meant to reject dispatch collisions. Normalize/lowercase the discriminator or key on decoded bytes plus length before inserting.Useful? React with 👍 / 👎.