Skip to content

test(metrics): use crossChain scope label instead of global - #1452

Merged
DZakh merged 2 commits into
mainfrom
claude/session-3eu3cw
Jul 21, 2026
Merged

test(metrics): use crossChain scope label instead of global#1452
DZakh merged 2 commits into
mainfrom
claude/session-3eu3cw

Conversation

@DZakh

@DZakh DZakh commented Jul 21, 2026

Copy link
Copy Markdown
Member

https://claude.ai/code/session_015i9PA3wbkHqxatp5tRZ5gJ

Summary by CodeRabbit

  • Bug Fixes
    • Updated Effect metrics output to use the crossChain scope label instead of global.
    • Corrected expected labels across timing, totals, call counts, active calls, cache, and queue metrics.
    • Preserved cache invalidation metrics without a scope label.

claude added 2 commits July 21, 2026 09:13
The effect scope Prometheus label is rendered as "crossChain" by
EffectCache.scopeToString, but the Metrics test fixture and expected
output still used the stale "global" value.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015i9PA3wbkHqxatp5tRZ5gJ
@DZakh
DZakh enabled auto-merge (squash) July 21, 2026 09:36
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3be7ac7e-e8e1-4d21-9518-5670195eda57

📥 Commits

Reviewing files that changed from the base of the PR and between d61cc48 and 5db0aa7.

📒 Files selected for processing (1)
  • scenarios/test_codegen/test/lib_tests/Metrics_test.res

📝 Walkthrough

Walkthrough

Updates the Metrics test fixture and expected Prometheus output to use crossChain for Effect metric scope labels, while leaving cache invalidations without a scope label.

Changes

Metrics scope expectations

Layer / File(s) Summary
Update effect metric scope assertions
scenarios/test_codegen/test/lib_tests/Metrics_test.res
The fixture derives its effect scope from CrossChain, and effect metric expectations now use scope="crossChain" across timing, count, active-call, cache, and queue metrics.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating metrics tests to use the crossChain scope label instead of global.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@DZakh
DZakh merged commit 3bcf417 into main Jul 21, 2026
8 checks passed
@DZakh
DZakh deleted the claude/session-3eu3cw branch July 21, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants