WIP: Use wire schema artifact#846
Draft
erlendnils1 wants to merge 21 commits into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
# Conflicts: # schema2proto-wire/pom.xml # schema2proto-wire/src/main/java/com/squareup/wire/schema/internal/parser/ProtoParser.java # schema2proto-wire/src/test/java/com/squareup/wire/schema/internal/parser/ProtoParserTest.kt
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire schema source code was forked and included in project for the initial version. Likely reason was the need for a mutable model for the schema (wire was, or perhaps at one point became, immutable).
This PR attempts to remove the local, hard to maintain fork and instead use latest wire schema artifact. To avoid having to rewrite absolutely everything a much simpler mutable model has been added as replacement for the full wire fork. Model is used for manipulating the schema, with conversion from and to ordinary wire model for schema parsing and printing.
NB! Current impl is mostly AI vibe. Need to review the code.