Do not add validation rules for optional attributes#732
Open
erlendnils1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional xsd attributes will currently generate protovalidate rules as if they are mandatory.
For instance:
<attribute name="srsDimension" type="positiveInteger"/>generates the following proto definition:
As xsd attributes are default optional the xml will allow omitting srsDimension. The proto schema will, however, require a positive integer value. It should allow omitting the field / specifying 0.
TODO:
How should this be handled? Current impl simply ignores optional attributes. We could probably create separate rule mappings for required/non required, ie mapping "postiveInteger"+required ->
(buf.validate.field).uint32.gt = 0and "postiveInteger"+non required ->(buf.validate.field).uint32.gte = 0.The validation annotation generation does, however, seem quite unfinished in it's current state. For elements it is completely disabled (by
if (false && configuration.includeValidationRules) { // TODO SKIP FOR NOW AS RULES ARE NOT COMPILING)