fixed issue with content hash encoding being undefined#130
Open
Abhimanyu121 wants to merge 1 commit into
Open
Conversation
Member
|
Thank you for the PR. can you let me know how to replicate the existing issue so that I can test whether this change has fixed it or not. |
Contributor
Author
|
when we call setContentWithResolver it consequently calls setContenthashWithResolver in which encodedContenthash was being directly passed to setContenthash instead of encodedContentHash. encoded |
|
The issue was that when we are calling the This PR fixes this issue |
Member
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Encoded content hash was under a key named encodedContenthash .encoded but encodedContenthash was being passed directly.