Skip to content

added visual effect to speed limiter#104

Open
AhmedOsama wants to merge 1 commit into
endor:masterfrom
AhmedOsama:master
Open

added visual effect to speed limiter#104
AhmedOsama wants to merge 1 commit into
endor:masterfrom
AhmedOsama:master

Conversation

@AhmedOsama

Copy link
Copy Markdown

Speed limiter now shows in Red when enabled on mobile devices

Comment thread css/mobile.css

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it necessary to redefine the width and height?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because its a sprite image, 1 image for both icons just to avoid any old
browser glitches

On Fri, Sep 26, 2014 at 8:37 AM, Frank Prößdorf notifications@github.com
wrote:

In css/mobile.css:

@@ -250,8 +250,15 @@ footer {
}

#mobile-footer .links li .speed_limit_mode {

  • background: transparent url(images/speed_mobile.png) no-repeat 0 0;
  • background-size: 100%;
  • background: transparent url('images/speed.png') no-repeat -34px -42px;
  • width: 32px;
  • height: 32px;
    +}

+#mobile-footer .links li .speed_limit_mode.active {

  • background: transparent url('images/speed.png') no-repeat -34px -3px !important;
  • width: 32px !important;

why is it necessary to redefine the width and height?


Reply to this email directly or view it on GitHub
https://github.com/endor/kettu/pull/104/files#r18075493.

@endor

endor commented Sep 26, 2014

Copy link
Copy Markdown
Owner

Thanks! That's a good idea.

Could you please remove the old image though?

Also, if you have the time, it'd be great if you could do the same for the compact mode, statistics, preferences and add torrent icons (:

@AhmedOsama

Copy link
Copy Markdown
Author

yea sure i'll have the old image removed and work on the compact mode, statistics, preferences and add torrent icons sometime later tomorrow (:

@endor

endor commented Oct 1, 2014

Copy link
Copy Markdown
Owner

@AhmedOsama still doing that? (:

@AhmedOsama

Copy link
Copy Markdown
Author

really busy these days ... unfortunately and we are about to have a civic holiday here so hopefully sometime next week if everything goes well

@Mariappan

Copy link
Copy Markdown
Contributor

@AhmedOsama Thank you very much for this commit. I was exactly looking for the same. Since on my mobile, I confused myself a lot to know whether the speed limiter is set or not.

@endor Thanks for this wonderful project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants