chore: update dependencies#43
Conversation
Closes #42 pg-sveltekit: - npm audit fix clears devalue GHSA-77vg-94rm-hx3p (high) and the four svelte SSR/DOM/ReDoS advisories (moderate) by lifting devalue and svelte past the patched versions. - Minor/patch: @e4a/pg-js 1.6.2 -> 1.8.0, @sveltejs/kit 2.59.1 -> 2.60.1, @types/node 25.7.0 -> 25.9.1, eslint 10.3.0 -> 10.4.0, svelte declared range -> ^5.55.8, typescript-eslint 8.59.3 -> 8.59.4. - cookie override stays: @sveltejs/kit 2.60.1 still pins cookie ^0.6.0. pg-manual: - Patch: @e4a/pg-wasm 0.6.0 -> 0.6.1, web-streams-polyfill 4.2.0 -> 4.3.0. - Major: @privacybydesign/yivi-{client,core,css,popup} 0.2 -> 1.x. v1 ships proper ESM with named exports, so examples/utils.js switches to `import { YiviCore } from ...` (etc). yivi.use(...) contract is unchanged; yivi-css stays a side-effect import. vite 7 -> 8 / vite-plugin-svelte 6 -> 7 held back: vite-plugin-top-level-await still `require('rollup')` at load and vite 8 dropped bundled rollup.
|
no CI workflow in this repo; please review manually |
Drops vite-plugin-top-level-await: it required `rollup` at module load and vite 8 swaps rollup for rolldown, so the plugin is unloadable there. With `build.target: 'esnext'`, vite 8 / rolldown passes top-level await through unchanged for modern browsers (Chrome 89+, Firefox 89+, Safari 15+), which the wasm plugin's init relies on. Concurrent TLA imports become sequential after bundling (rolldown semantics), so init may be marginally slower but still correct. - vite 7.3.2 -> 8.0.13 - @sveltejs/vite-plugin-svelte 6.2.4 -> 7.1.2 - remove vite-plugin-top-level-await
|
/dobby review this pr |
|
Dobby has heard the request and Dobby is on it! Dobby will read this pull request carefully and post a review with a clear verdict. |
There was a problem hiding this comment.
Verdict: ready to merge (Dobby cannot self-approve as the PR author — flagging here so a human can land it).
Local verification on the PR branch:
pg-sveltekit
npm install— 0 vulnerabilities, no peer-dep ERESOLVE.npm run build— clean, 621 ms (rolldown via vite 8).npm run check— 294 files, 0 errors, 0 warnings (the previously-expected svelte runes warning is gone).npm audit— 0 vulnerabilities. Thedevalue/svelteadvisories listed in the PR body are cleared.- Vite 8 + vite-plugin-svelte 7 chain is fine after dropping
vite-plugin-top-level-await.build.target: 'esnext'is correctly retained — needed now to keep rolldown from down-transforming TLA, whichvite-plugin-wasm's WASM init relies on. overrides.cookie: ^0.7.2correctly kept;@sveltejs/kit@2.60.1still pinscookie ^0.6.0.
pg-manual
npm install— 0 vulnerabilities.npm run build— webpack 5.106.2 compiled successfully in 269 ms, noexport … was not foundwarnings.- yivi 0.2 → 1.x migration in
examples/utils.jsis correct: named imports give a callable constructor under the v1 ESM shape;yivi.use(YiviClient)/yivi.use(YiviPopup)plugin contract is unchanged. file.jsalready uses theWritableStream as PolyfilledWritableStreamform, so theweb-streams-polyfill4.2 → 4.3 patch bump is benign.
Caveat from the PR body still stands: a browser encrypt/decrypt round-trip hasn't been smoke-tested under the new TLA path. Static analysis and build output look right; a quick npm run dev round-trip before merging would close the loop. Not blocking.
|
This agent sees the approval from @rubenhensen — and the PR is already merged! Dobby is so happy: the dependency sweep is landed, issue #42 auto-closed, and no tracking issue needed updating. Dobby thanks the kind master for the review! |
Closes #42
pg-sveltekit
Security advisories cleared by
npm audit fix:devaluepast 5.6.3–5.8.0 — GHSA-77vg-94rm-hx3p (high, DoS via sparse-array deserialization).svelteto^5.55.8— clears GHSA-pr6f-5x2q-rwfp, GHSA-f3cj-j4f6-wq85, GHSA-rcqx-6q8c-2c42, GHSA-9rmh-mm8f-r9h6 (moderate).Minor/patch bumps:
@e4a/pg-js1.6.2 → 1.8.0@sveltejs/kit2.59.1 → 2.60.1@types/node25.7.0 → 25.9.1eslint10.3.0 → 10.4.0typescript-eslint8.59.3 → 8.59.4Major bump —
vite7.3.2 → 8.0.13 and@sveltejs/vite-plugin-svelte6.2.4 → 7.1.2. Removedvite-plugin-top-level-await: it doesrequire('rollup')at module load, and vite 8 replaces rollup with rolldown so the plugin no longer resolves. Withbuild.target: 'esnext', vite 8 / rolldown passes top-level await through unchanged for modern browsers (Chrome 89+, Firefox 89+, Safari 15+), which is whatvite-plugin-wasm's WASM init relies on. Side effect: concurrent TLA imports become sequential after bundling (rolldown semantics) — init may be marginally slower but still correct.overrides.cookie: ^0.7.2stays —@sveltejs/kit@2.60.1still pinscookie ^0.6.0.pg-manual
Patch bumps:
@e4a/pg-wasm0.6.0 → 0.6.1web-streams-polyfill4.2.0 → 4.3.0Major bump —
@privacybydesign/yivi-{client,core,css,popup}0.2.1 → 1.x. v1 ships proper ESM with named exports, soexamples/utils.jsswitches fromimport * as YiviCoretoimport { YiviCore }(same forYiviClient/YiviPopup). Theyivi.use(...)plugin contract is unchanged;yivi-cssstays a side-effect import.Verification
pg-sveltekit:npm install && npm run build && npm run check→ clean (0 errors / 0 warnings on vite 8.0.13). Browser encrypt/decrypt round-trip not yet smoke-tested under the new TLA path — recommended before merge.pg-manual:npm install && npm run build→ clean, noexport … not foundwarnings.