Skip to content

[DEVEX-1523] Bump AI reviewer max_turns to 10#123

Merged
revolutionpartsadmin merged 1 commit into
mainfrom
DEVEX-1523-bump-max-turns
May 19, 2026
Merged

[DEVEX-1523] Bump AI reviewer max_turns to 10#123
revolutionpartsadmin merged 1 commit into
mainfrom
DEVEX-1523-bump-max-turns

Conversation

@ronneseth
Copy link
Copy Markdown
Contributor

Summary

  • Bumps default max_turns from 5 to 10
  • Claude was exhausting turns on larger diffs (e.g., 350-line CODEOWNERS changes) before submitting the review

JIRA: DEVEX-1523

Made with Cursor

@ronneseth ronneseth requested a review from a team as a code owner May 19, 2026 21:12
@ronneseth ronneseth requested a review from aspencer May 19, 2026 21:12
@cursor
Copy link
Copy Markdown

cursor Bot commented May 19, 2026

PR Summary

Low Risk
Low risk CI workflow-only change; it increases compute/usage for the AI review job and may mask failures by allowing the action step to continue on error.

Overview
Claude AI review workflow behavior changes. The default max_turns input is increased from 5 to 20 so the reviewer can handle larger diffs without exhausting turns.

The anthropics/claude-code-action@v1 step is now continue-on-error: true, so PRs won’t be blocked if the AI review action fails.

Reviewed by Cursor Bugbot for commit 142f275. Bugbot is set up for automated code reviews on this repo. Configure here.

@ronneseth ronneseth force-pushed the DEVEX-1523-bump-max-turns branch from de8f88c to 892c238 Compare May 19, 2026 21:13
Claude was hitting the turn limit on larger diffs before it could
submit the review. Bump to 20 for headroom on large PRs. Also add
continue-on-error so Claude failures never block the CI check — the
review is advisory, not a gate.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ronneseth ronneseth force-pushed the DEVEX-1523-bump-max-turns branch from 892c238 to 142f275 Compare May 19, 2026 21:14
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 142f275. Configure here.

required: false
type: number
default: 5
default: 20
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default max_turns mismatch

Low Severity

The reusable workflow sets max_turns default to 20, but the PR title and description (DEVEX-1523) specify bumping the default to 10. Callers that rely on the documented default may run twice as many turns as intended, increasing latency and API cost.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 142f275. Configure here.

fetch-depth: 0

- uses: anthropics/claude-code-action@v1
continue-on-error: true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review failures hidden

Medium Severity

continue-on-error: true on the Claude review step lets the job finish successfully when the step fails, with no later step checking steps.*.outcome. Required checks or automation can treat a failed or incomplete AI review as a pass.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 142f275. Configure here.

@revolutionpartsadmin revolutionpartsadmin merged commit 81cdda6 into main May 19, 2026
2 checks passed
@revolutionpartsadmin revolutionpartsadmin deleted the DEVEX-1523-bump-max-turns branch May 19, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants