perf: skip 3s DWN discovery for returning users and parallelize registration#78
Open
LiranCohen wants to merge 1 commit into
Open
perf: skip 3s DWN discovery for returning users and parallelize registration#78LiranCohen wants to merge 1 commit into
LiranCohen wants to merge 1 commit into
Conversation
…tration Skip the unconditional 3-second local DWN discovery wait when the user has a cached session PIN (returning user). Also resolve early via hashchange event if the local DWN responds before the timeout. Parallelize DWN tenant registration: fetch server info for all endpoints concurrently, then register all DIDs on all reachable endpoints in parallel instead of sequential endpoint x DID nested loops.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses slow wallet unlock and page reload by fixing the two biggest bottlenecks in the wallet's initialization path.
Changes
Skip 3-second DWN discovery wait for returning users (
provider.tsx)The
init()function unconditionally waited 3 seconds for local DWN discovery on every desktop page load — even when the user has a cached session PIN (i.e., a returning user refreshing the tab). This blocked the entire auth initialization pipeline.Fix:
sessionStorage). Returning users already have persisted endpoints.hashchangeevent if the local DWN responds before the timeout, instead of always burning the full 3 seconds.Parallelize DWN tenant registration (
registration.ts)ensureRegistration()was iterating endpoints sequentially, and within each endpoint iterating DIDs sequentially. With 2 endpoints and 3 identities, that's 8 sequential HTTP round-trips.Fix:
serverInfofor all endpoints concurrently viaPromise.allSettled().Promise.all().Expected Impact
Verification
npx tsc --noEmitpassesbun run buildpasses