Stabilize profile image object URLs#106
Closed
LiranCohen wants to merge 2 commits into
Closed
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
Closing this in favor of a clean branch based on current main. The replacement PR contains only the profile image object URL fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<img>sourcesWhy
After discovered-identity sync started invalidating profile queries correctly, React Query can refetch profile data while the UI is still rendering the previous result. The old
fetchProfile()revoked previous object URLs at the start of every refetch, which made the browser try to load revokedblob:URLs and lognet::ERR_FILE_NOT_FOUNDeven though the UI recovered quickly.Tests
bun run test -- src/enbox/queries/__tests__/identity-queries.test.ts src/enbox/__tests__/identity-sync.test.ts src/enbox/hooks/__tests__/use-identity-sync-reconciliation.test.tsx src/enbox/hooks/__tests__/use-sync-query-invalidation.test.tsxbunx tsc -bbun run testbun run lint(passes with existing Testing Library warnings)bun run build(passes with existing chunk-size warnings)