Stabilize identity creation sync flow#102
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
00be496 to
504dd2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Identity not foundprotocols: 'all'Follow-up design note
The remaining
ProtocolsConfigureComposedProtocolNotInstalledissue should be fixed in the Enbox SDK sync layer, not by broadening wallet sync. The SDK should support a grouped protocol-set sync target so explicit protocol lists share one ordered push queue/checkpoint, and it should order composed protocol config dependencies such as SocialGraph before Profile.Test plan
bun run test -- src/enbox/hooks/__tests__/use-identity-mutations.test.tsxbun run buildbun run lint(passes with existing Testing Library warnings)git diff --check origin/main