Skip to content

Stabilize identity creation sync flow#102

Merged
LiranCohen merged 1 commit into
mainfrom
codex/stabilize-identity-sync-flow
May 27, 2026
Merged

Stabilize identity creation sync flow#102
LiranCohen merged 1 commit into
mainfrom
codex/stabilize-identity-sync-flow

Conversation

@LiranCohen

@LiranCohen LiranCohen commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • seed the identities query cache with the newly created identity before invalidation/refetch so navigating to the new detail route does not briefly show Identity not found
  • keep web-wallet identity sync scoped to the explicit wallet protocol list instead of broadening to protocols: 'all'
  • add focused tests for the create-identity cache update behavior

Follow-up design note

The remaining ProtocolsConfigureComposedProtocolNotInstalled issue should be fixed in the Enbox SDK sync layer, not by broadening wallet sync. The SDK should support a grouped protocol-set sync target so explicit protocol lists share one ordered push queue/checkpoint, and it should order composed protocol config dependencies such as SocialGraph before Profile.

Test plan

  • bun run test -- src/enbox/hooks/__tests__/use-identity-mutations.test.tsx
  • bun run build
  • bun run lint (passes with existing Testing Library warnings)
  • git diff --check origin/main

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 36.43% (🎯 25%) 724 / 1987
🔵 Statements 35.41% (🎯 25%) 789 / 2228
🔵 Functions 39.47% (🎯 30%) 227 / 575
🔵 Branches 34.22% (🎯 29%) 498 / 1455
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/enbox/hooks/use-identity-mutations.ts 43.18% 71.42% 36.36% 42.5% 27, 35, 62-118
Generated in workflow #270 for commit 504dd2b by the Vitest Coverage Report Action

@LiranCohen LiranCohen force-pushed the codex/stabilize-identity-sync-flow branch from 00be496 to 504dd2b Compare May 27, 2026 20:10
@LiranCohen LiranCohen merged commit 186cefb into main May 27, 2026
4 checks passed
@LiranCohen LiranCohen deleted the codex/stabilize-identity-sync-flow branch May 27, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant