chore: bump @enbox/browser to ^0.3.8 (surface JWS verifier diagnostics)#42
Merged
Merged
Conversation
Pulls in @enbox/dwn-sdk-js@0.3.5 transitively, which surfaces DID and resolution metadata in GeneralJwsVerifierGetPublicKeyNotFound errors (enboxorg/enbox#909). This makes wallet-connect failures actionable: instead of just "public key needed to verify signature not found in DID Document", the error now indicates whether DID resolution failed (with the underlying resolution error) or the kid did not match any verification method (listing the available method IDs). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@enbox/browser^0.3.7->^0.3.8, which transitively pulls in@enbox/dwn-sdk-js@0.3.5.GeneralJwsVerifierGetPublicKeyNotFound: public key needed to verify signature not found in DID Documenterror with a diagnostic that distinguishes:kidmismatches (lists the verification method IDs that are in the DID Document).Why
When testing the mobile wallet-connect flow, nutsd surfaced the generic
not found in DID Documenterror after the verification PIN was entered, with no way to tell whether the wallet'sdid:dhtfailed to resolve or whether thekidsimply didn't match. This bump makes the next reproduction self-describing so we can pinpoint the actual cause.Test plan
bun installresolves@enbox/dwn-sdk-js@0.3.5bun run lintcleanbun run buildclean (PWA + service worker)bun run test-> 312 passed, 26 filesMade with Cursor