Support native mobile wallet connect flow#40
Merged
Conversation
Align nutsd to the current Enbox connect stack and expose a mobile-first wallet path in the QR dialog so users can open Enbox Mobile directly or copy the connect link for same-device flows.
LiranCohen
force-pushed
the
feat/mobile-wallet-connect-requester
branch
from
54cbc2a to
785749a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes
/home/liran/src/enboxorg/nutsd/src/components/wallet/pay-request-dialog.tsx
66:43 error React Hook "useState" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return? react-hooks/rules-of-hooks
/home/liran/src/enboxorg/nutsd/src/components/wallet/receive-dialog.tsx
144:11 error 'knownMint' is never reassigned. Use 'const' instead prefer-const
/home/liran/src/enboxorg/nutsd/src/hooks/use-wallet.ts
1141:13 error 'mint' is never reassigned. Use 'const' instead prefer-const
1255:6 warning React Hook useCallback has a missing dependency: 'addMint'. Either include it or remove the dependency array react-hooks/exhaustive-deps
✖ 4 problems (3 errors, 1 warning)
2 errors and 0 warnings potentially fixable with the
--fixoption. still fails on pre-existing issues outside this change: