fix: mcp install password gap + per-profile sidecar path#58
Merged
Conversation
…decar path - serverEntry() now includes MEMORYD_PASSWORD in env when set - warnIfNoPassword() prints a warning after install if MEMORYD_PASSWORD is unset - main.ts derives sidecar path from active profile (~/.enbox/profiles/<name>/index.db) so different identities don't cross-contaminate the search index - Add tests for password inclusion, warning, and per-profile sidecar override
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #56
serverEntry()now includesMEMORYD_PASSWORDin theenvblock when the variable is set, so MCP clients launched via stdio can authenticate without prompting on stdin.mcp install, prints a warning ifMEMORYD_PASSWORDis not set, explaining that stdio transport will fail without it.main.tsnow derives the sidecar SQLite path from the active profile (~/.enbox/profiles/<name>/index.db) instead of using the global~/.memoryd/index.db. This prevents different identities from cross-contaminating the search index.Tests
tests/cli/mcp.spec.ts: password inclusion/omission in config, warning presence/absencetests/config.spec.ts: per-profile sidecar path overrideVerification
bun run build— zero errorsbun test .spec.ts— 255 tests pass (21 files)bun run lint— zero warnings