fix: warn when using noop embedding provider and document search setup#54
Merged
Conversation
LiranCohen
force-pushed
the
fix/embedding-ux
branch
2 times, most recently
from
aced08f to
046986c
Compare
Print a clear warning during init and serve when the noop embedding provider is active, directing users to set MEMORYD_EMBEDDING_PROVIDER to ollama or openai for full hybrid search. Add a Search Setup section to README documenting the three providers (noop, ollama, openai) with configuration examples. Closes #50
LiranCohen
force-pushed
the
fix/embedding-ux
branch
from
046986c to
8610e36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memoryd initandmemoryd servewhen using the noop embedding provider, directing users to setMEMORYD_EMBEDDING_PROVIDER=ollamaor=openaiBuild, test, and lint all pass.
Closes #50