update water.cpp: modify set_wwCircTc to use new command values#3149
Merged
Conversation
Contributor
|
Oh, it fixes dhw3 on SM100, but i see too late that it breaks MM1100 dhw1/2 setting. I'll fix with next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted change to the
Water::set_wwCircTcmethod, updating the way commands are written when setting a value.Device command update:
write_commandcall inWater::set_wwCircTcto use a fixed address (0x7A5) and updated the command value to0xFFwhen enabled (previously used a variable address and0x01).Behavior in my system using the SM100 with a Buderus FS20 was wrong and didn't worked.
With the changed implementation controlling Timed based circulation On/Off worked fine.