Make use externref + multivalue to speed up emscripten_atomic_wait_suspending#26964
Open
sbc100 wants to merge 1 commit into
Open
Make use externref + multivalue to speed up emscripten_atomic_wait_suspending#26964sbc100 wants to merge 1 commit into
sbc100 wants to merge 1 commit into
Conversation
tlively
reviewed
May 15, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Can you gate this change on JSPI being enabled? I'd say it's unlikely that we will update Asyncify to support reference types.
| #endif | ||
| // In the synchronous case return the negative result code | ||
| return -atomicWaitStates.indexOf(wait.value); | ||
| return [undefined, atomicWaitStates.indexOf(wait.value)] |
Member
There was a problem hiding this comment.
null would make more sense than undefined here. That way you end up with a null externref on the Wasm side. With undefined, you end up with a non-null externref.
Collaborator
Author
We would need to have a custom version of libc (or some other support library) in that case. Right now we don't have an ASYNCIFY build of or libc or a JSPI one.. its all the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently blocked on WebAssembly/binaryen#3739.
Mostly uploading as an example of how its possible to use externref (in both C and asm code) and multi-value (in JS and asm code) today.