Skip to content

fix(modbus): handle malloc/pthread_create errors in set_skip_timer #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengzeroz merged 1 commit into from
Jul 13, 2026
Merged

fix(modbus): handle malloc/pthread_create errors in set_skip_timer #2901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion plugins/modbus/modbus_req.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,13 +332,23 @@ void set_skip_timer(uint8_t slave_id, uint32_t degrade_time)
{
degrade_timer_data_t *data =
(degrade_timer_data_t *) malloc(sizeof(degrade_timer_data_t));
if (data == NULL) {
skip[slave_id] = false;
return;
}

data->slave_id = slave_id;
data->degrade_time = degrade_time;

failed_cycles[slave_id] = 0;

pthread_t timer_thread;
pthread_create(&timer_thread, NULL, degrade_timer, data);
int ret = pthread_create(&timer_thread, NULL, degrade_timer, data);
if (ret != 0) {
free(data);
skip[slave_id] = false;
return;
}

pthread_detach(timer_thread);
}
Expand Down
Loading