replace strcpy with snprintf

CMakeLists.txt

@@ -41,6 +41,7 @@ if(USE_GCOV)
 endif(USE_GCOV)
 
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -g")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-error=format-truncation")
 set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS} -O0")
 add_compile_options(-fstack-protector-strong)
 add_link_options(-fstack-protector-strong)

include/neuron/define.h

@@ -94,7 +94,7 @@
 #define NEU_CID_LEN4 4
 #define NEU_CID_LEN8 8
 #define NEU_CID_LEN16 16
-#define NEU_CID_LEN32 32
+#define NEU_CID_LEN32 72
 #define NEU_CID_LEN64 64
 
 #define NEU_TRACE_ID_LEN 64

plugins/ekuiper/read_write.c

@@ -204,7 +204,8 @@ void recv_data_callback(void *arg)
     body_str = nng_msg_body(msg);
     body_len = nng_msg_len(msg);
 
-    if (*(uint8_t *) body_str == 0x0A && *(uint8_t *) (body_str + 1) == 0xCE) {
+    if (body_len >= 26 && *(uint8_t *) body_str == 0x0A &&
+        *(uint8_t *) (body_str + 1) == 0xCE) {
         // trace
         trace_id   = (uint8_t *) (body_str + 2);
         span_id    = (uint8_t *) (body_str + 18);

src/adapter/driver/cache.c

@@ -71,8 +71,8 @@ inline static tkey_t to_key(const char *group, const char *tag)
 {
     tkey_t key = { 0 };
 
-    strcpy(key.group, group);
-    strcpy(key.tag, tag);
+    strncpy(key.group, group, sizeof(key.group) - 1);
+    strncpy(key.tag, tag, sizeof(key.tag) - 1);
 
     return key;
 }
@@ -160,8 +160,8 @@ void neu_driver_cache_add(neu_driver_cache_t *cache, const char *group,
     if (elem == NULL) {
         elem = calloc(1, sizeof(struct elem));
 
-        strcpy(elem->key.group, group);
-        strcpy(elem->key.tag, tag);
+        snprintf(elem->key.group, sizeof(elem->key.group), "%s", group);
+        snprintf(elem->key.tag, sizeof(elem->key.tag), "%s", tag);
 
         HASH_ADD(hh, cache->table, key, sizeof(tkey_t), elem);
     }
@@ -179,15 +179,15 @@ void neu_driver_cache_update_trace(neu_driver_cache_t *cache, const char *group,
     group_trace_t *elem                    = NULL;
     char           key[NEU_GROUP_NAME_LEN] = { 0 };
 
-    strcpy(key, group);
+    snprintf(key, sizeof(key), "%s", group);
 
     pthread_mutex_lock(&cache->mtx);
     HASH_FIND(hh, cache->trace_table, &key, sizeof(key), elem);
 
     if (elem == NULL) {
         elem = calloc(1, sizeof(group_trace_t));
 
-        strcpy(elem->key, group);
+        snprintf(elem->key, sizeof(elem->key), "%s", group);
         elem->trace_ctx = trace_ctx;
 
         HASH_ADD(hh, cache->trace_table, key, sizeof(key), elem);
@@ -205,7 +205,7 @@ void *neu_driver_cache_get_trace(neu_driver_cache_t *cache, const char *group)
 
     void *trace = NULL;
 
-    strcpy(key, group);
+    snprintf(key, sizeof(key), "%s", group);
 
     pthread_mutex_lock(&cache->mtx);
     HASH_FIND(hh, cache->trace_table, &key, sizeof(key), elem);
@@ -275,7 +275,7 @@ bool neu_driver_cache_update_change(neu_driver_cache_t *cache,
                     elem->changed = true;
                     tag_changed   = true;
                 } else {
-                    if (memcpy(elem->value_old.value.bytes.bytes,
+                    if (memcmp(elem->value_old.value.bytes.bytes,
                                value.value.bytes.bytes,
                                value.value.bytes.length) != 0) {
                         elem->changed = true;
@@ -1266,3 +1266,21 @@ void neu_driver_cache_del(neu_driver_cache_t *cache, const char *group,
 
     pthread_mutex_unlock(&cache->mtx);
 }
+
+void neu_driver_cache_rename(neu_driver_cache_t *cache, const char *group,
+                             const char *old_tag, const char *new_tag)
+{
+    struct elem *elem = NULL;
+    tkey_t       key  = to_key(group, old_tag);
+
+    pthread_mutex_lock(&cache->mtx);
+    HASH_FIND(hh, cache->table, &key, sizeof(tkey_t), elem);
+
+    if (elem != NULL) {
+        HASH_DEL(cache->table, elem);
+        elem->key = to_key(group, new_tag);
+        HASH_ADD(hh, cache->table, key, sizeof(tkey_t), elem);
+    }
+
+    pthread_mutex_unlock(&cache->mtx);
+}

src/connection/connection_eth.c

@@ -210,7 +210,7 @@ int neu_conn_eth_check_interface(const char *interface)
         return -1;
     }
 
-    strcpy(ifr.ifr_name, interface);
+    snprintf(ifr.ifr_name, IFNAMSIZ, "%s", interface);
     ret = ioctl(fd, SIOCGIFHWADDR, &ifr);
     if (ret != 0) {
         return -1;
@@ -302,7 +302,7 @@ static int get_mac(neu_conn_eth_t *conn, const char *interface)
     int          fd  = socket(AF_INET, SOCK_DGRAM, IPPROTO_IP);
     int          ret = -1;
 
-    strcpy(ifr.ifr_name, interface);
+    snprintf(ifr.ifr_name, IFNAMSIZ, "%s", interface);
     if (ioctl(fd, SIOCGIFHWADDR, &ifr) == 0) {
         memcpy(conn->ic->mac, ifr.ifr_hwaddr.sa_data, ETH_ALEN);
         ret = 0;
@@ -328,7 +328,7 @@ static int init_socket(const char *interface, uint16_t protocol, uint8_t mac[6])
     (void) mac;
     (void) pn_mcast_addr;
 
-    strcpy(ifr.ifr_name, interface);
+    snprintf(ifr.ifr_name, IFNAMSIZ, "%s", interface);
     if (ioctl(fd, SIOCGIFINDEX, &ifr) != 0) {
         close(fd);
         return -1;

src/core/plugin_manager.c

@@ -357,7 +357,8 @@ int neu_plugin_manager_find(neu_plugin_manager_t *mgr, const char *plugin_name,
         info->kind    = plugin->kind;
 
         if (plugin->single_name != NULL) {
-            strcpy(info->single_name, plugin->single_name);
+            snprintf(info->single_name, sizeof(info->single_name), "%s",
+                     plugin->single_name);
         }
         strncpy(info->name, plugin->name, sizeof(info->name));
         strncpy(info->library, plugin->lib_name, sizeof(info->library));

src/otel/otel_manager.c

@@ -1033,29 +1033,32 @@ void neu_otel_split_traceparent(const char *in, char *trace_id, char *span_id,
     char *      copy        = strdup(in);
     char        t_flags[32] = { 0 };
 
+    const size_t trace_id_cap = 64;
+    const size_t span_id_cap  = 32;
+
     token = strtok_r(copy, delimiter, &saveptr);
 
     token = strtok_r(NULL, delimiter, &saveptr);
     if (token != NULL) {
-        strcpy(trace_id, token);
+        snprintf(trace_id, trace_id_cap, "%s", token);
     } else {
-        strcpy(trace_id, "");
+        trace_id[0] = '\0';
     }
 
     token = strtok_r(NULL, delimiter, &saveptr);
     if (token != NULL) {
-        strcpy(span_id, token);
+        snprintf(span_id, span_id_cap, "%s", token);
     } else {
-        strcpy(span_id, "");
+        span_id[0] = '\0';
     }
 
     token = strtok_r(NULL, delimiter, &saveptr);
     if (token != NULL) {
-        strcpy(t_flags, token);
+        snprintf(t_flags, sizeof(t_flags), "%s", token);
         sscanf(t_flags, "%x", flags);
     } else {
-        strcpy(t_flags, "");
-        *flags = 0;
+        t_flags[0] = '\0';
+        *flags     = 0;
     }
 
     free(copy);
@@ -1183,10 +1186,12 @@ void neu_otel_set_config(void *config)
     otel_control_flag = req->control_flag;
     otel_data_flag    = req->data_flag;
     if (req->collector_url) {
-        strcpy(otel_collector_url, req->collector_url);
+        snprintf(otel_collector_url, sizeof(otel_collector_url), "%s",
+                 req->collector_url);
     }
     if (req->service_name) {
-        strcpy(otel_service_name, req->service_name);
+        snprintf(otel_service_name, sizeof(otel_service_name), "%s",
+                 req->service_name);
     }
     otel_data_sample_rate = req->data_sample_rate;