[v2.12]refactor(json): change array length type from uint16_t to size_t#2844
Closed
ZhouBox wants to merge 2 commits into
Closed
[v2.12]refactor(json): change array length type from uint16_t to size_t#2844ZhouBox wants to merge 2 commits into
ZhouBox wants to merge 2 commits into
Conversation
- Replace uint16_t length with size_t in all neu_json_value_array_* structs - Fix sign-compare warnings in loop iterators (int -> size_t) - Fix transposed calloc arguments in restful rw_handle
Comparing the array address addr.sun_path with 0 is always false. Check sun_path[1] instead, matching the abstract socket convention where sun_path[0] is always '\0'.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.12 #2844 +/- ##
===========================================
+ Coverage 39.88% 65.41% +25.53%
===========================================
Files 108 121 +13
Lines 23228 27808 +4580
===========================================
+ Hits 9264 18191 +8927
+ Misses 13964 9617 -4347 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.