Skip to content

[v2.12]fix: handle NULL json_str case to avoid undefined behavior #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengzeroz merged 1 commit into from
Jul 22, 2025
Merged

[v2.12]fix: handle NULL json_str case to avoid undefined behavior #2522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/mqtt/mqtt_handle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,7 +1491,9 @@ int handle_trans_data(neu_plugin_t * plugin,
plugin, trans_data, plugin->config.format,
plugin->config.schema_vts, plugin->config.n_schema_vt,
static_tags, n_satic_tag, &skip_none);
size = strlen(json_str);
if (json_str != NULL) {
size = strlen(json_str);
}
}

Copilot AI Jul 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing brace appears to be misaligned or creates unbalanced braces. The NULL check for json_str should wrap only the strlen() operation, but this closing brace suggests it may be closing an outer scope incorrectly.

Suggested change
}

Copilot uses AI. Check for mistakes.
if (n_satic_tag > 0) {
mqtt_static_free(static_tags, n_satic_tag);
Expand Down