feat(journal): W1 「我的手帐」 — /me/journal page for logged-in users#51
Open
emptylower wants to merge 13 commits into
Open
feat(journal): W1 「我的手帐」 — /me/journal page for logged-in users#51emptylower wants to merge 13 commits into
emptylower wants to merge 13 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ames Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
W1 of the 6-week MVP: new private route
/me/journalthat renders a logged-in user's personal "pilgrimage handbook" — cover + 7 data-viz sections + 4 explore cards + LBS floating button, in a paper-journal visual style.lib/journal/domain following the existing 3-layer pattern (api factory → handler → repo Prisma + Memory double)PaperCard,RedSeal,WashiTape,InkDivider,StitchedBorder,PageFoldCorner) underapp/(authed)/me/journal/primitives/node+jsdomprojects, all greenOut of scope (W1 NOT-doing list)
Per the W1 plan and product charter §9, these are explicitly deferred:
/me/journalis a new route, not a redirect target — W4 handles route migration)recentNotesalways returns[](notes write/read system is W2+)travelModeBreakdownis a static stub (real per-user calculation is W2+)Charter compliance (docs/product-charter.md)
One plan deviation worth flagging
Task 4's Prisma repo uses
state: 'checked_in'instead of the plan's'visited'. The valid enum in lib/userPointState/repo.ts is'want_to_go' | 'planned' | 'checked_in'; without the correction, every user's check-in count would have been 0 in production.Follow-ups for W2 (non-blocking)
listCheckinshas notakelimit; heavy users force large fetches + in-memory haversine on every page hit.countDistinctWorksVisitedusesdistinct: ['pointId']+ JS Set; agroupBy({ by: ['bangumiId'] })would be cheaper.unlockedAt = nowis computed at view time; AchievementWall tooltip will show "unlocked today" for all unlocked badges until W2 introduces persistent unlock timestamps.Test plan
npx vitest run tests/journal/→ 43 passed (21 node + 22 jsdom)npx tsc -p tsconfig.app.json --noEmit→ no new journal type errors🤖 Generated with Claude Code