Streamlines materials ontology and refines core concepts#407
Open
emanueleghedini wants to merge 29 commits into
Open
Streamlines materials ontology and refines core concepts#407emanueleghedini wants to merge 29 commits into
emanueleghedini wants to merge 29 commits into
Conversation
…pension, and Colloid
[annotations][metrology] moved iupacReference from metrology to annotations [materials] added several subclasses [physicalistic] annotation reviews
[materials] Added Amorphous and Crystalline States [annotations] typo correction [manufacturing] corrected wrong sub-property relation for manufacturedBy
[materials] added uncondensed matter [materials] crystalline state can be solid or liquid
[materials] Added functional subclasses, updated nanomaterials, isotropy classification
[materials] added materials classes from Callister book
Feat: Introduce and refine foundational functional material concepts (Batch 1) Feat: Introduce foundational electrical and mechanical response material categories and specific types Feat: Introduce dielectric, ferroic, and initial optical materials Feat: Add various magnetic and related material definitions (Batch 1) Feat: Complete specific mechanical, electrical, thermal, and adaptive materials
feat(materials): Add etymology annotations for concepts refactor(materials): Refine definitions and notes for core concepts fix(materials): Correct OWL cardinality axioms
fix: Adjust OWL cardinality axioms
…nd PolyCrystallineMaterial refactor(materials): Adjust OWL cardinality axioms
refactor: Refine amorphous material definitions feat: Enhance CeramicMaterial definition with examples and conceptualisation feat: Add UnitCell as alternative label for CrystalCell fix: Fix typo in CompactedGraphiteIron style: Reformat AllDisjointClasses axiom for readability
feat: Enhance SingleCrystal definition and metadata docs: Fix typo in MolecularEntity conceptualisation
|
|
||
|
|
||
| ################################################################# | ||
| # Classes | ||
| ################################################################# | ||
|
|
||
| ### http://purl.org/dc/dcmitype/Text | ||
| dcmitype:Text rdf:type owl:Class . |
Contributor
There was a problem hiding this comment.
Make dcmitype:Text a subclass of SymbolicConstruc. This will avoid that Text turns up at the top-level taxonomy next to EMMO.
Contributor
|
For references, it would be nice with documentation of when we are using rdfs:seeAlso and rdfs:isDefinedBy. |
| :EMMO_8b1367d6_0133_4b56_acc1_fa8b058169e3 ; | ||
| skos:prefLabel "ParticulateMatter"@en ; | ||
| :elucidation "Bounded matter."@en . | ||
| :elucidation "Matter in the form of particulate of bonded constituents."@en . |
Contributor
There was a problem hiding this comment.
Would be useful with a note stating that with "particulate" we refer to distinct individual particles rather than a continuous mass.
| :elucidation "Categorisation of matter by its structure."@en . | ||
| :conceptualisation "Matter can be categorized according to its structure in two types, by drawing a line between particulate matter (i.e., from elementary particles up to molecules) and aggregate of such particulates. When such aggregates show an homogeneity of property, according to some criteria, we call it a substance."@en ; | ||
| :elucidation "Categorisation of matter by its structure."@en ; | ||
| :note "Particulate matter and substance are not a covering for matter. Non-particulate matter are not represented with a class for simplicity."@en . |
Contributor
There was a problem hiding this comment.
Most substances are non-particulate. Would be useful with an example of non-particulate matter that is not a substance.
| owl:annotatedSource :EMMO_bc37743c_37c4_4ec7_9d58_d1aae5567352 ; | ||
| owl:annotatedProperty skos:prefLabel ; | ||
| owl:annotatedTarget "Substance"@en ; | ||
| :etymology "From Latin substantia (“substance, essence”), from substāns, present active participle of substō (“exist”, literally “stand under”), from sub + stō (“stand”) [Wikictionary]"@en |
Contributor
There was a problem hiding this comment.
Do you mean "wiktionary". Maybe add a link: https://en.wiktionary.org/wiki/substance#Etymology
jesper-friis
left a comment
jesper-friis
left a comment
Contributor
There was a problem hiding this comment.
Very nice. Added a few minor comments.
…sol' refactor: Refine 'Vapor' definition and update its superclass for accuracy feat: Add new reference for materials modelling review feat: Enhance conceptualisation and add external references for Mesoscopic and Continuum Substances
[materials] introduced several subclasses distinguishing between vapor and supercritical gaseous state
State of matter module now acts as intermediate layer between physicalistic and materials. Moved bonded atom, ion and neutral to chemistry module Authoritative sources now are placed when they are first used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant refactoring and simplification across several EMMO modules, primarily focusing on the
materialsdiscipline.