🎨 Palette: Add native typing sounds to terminal accessory keys#1801
🎨 Palette: Add native typing sounds to terminal accessory keys#1801emkey1 wants to merge 3 commits into
Conversation
Adds `UIInputViewAudioFeedback` conformance to `TerminalKeyInputView` and invokes `UIDevice.current.playInputClick()` in the action handlers for all custom accessory bar keys (escape, tab, arrows, modifiers, etc.) so that typing on the custom terminal bar correctly provides native audio and haptic feedback, matching standard iOS keyboard behavior. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Adds `UIInputViewAudioFeedback` conformance to `TerminalKeyInputView` and invokes `UIDevice.current.playInputClick()` in the action handlers for all custom accessory bar keys (escape, tab, arrows, modifiers, etc.) so that typing on the custom terminal bar correctly provides native audio and haptic feedback, matching standard iOS keyboard behavior. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
Adds `UIInputViewAudioFeedback` conformance to `TerminalKeyInputView` and invokes `UIDevice.current.playInputClick()` in the action handlers for all custom accessory bar keys (escape, tab, arrows, modifiers, etc.) so that typing on the custom terminal bar correctly provides native audio and haptic feedback, matching standard iOS keyboard behavior. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
1 participant
💡 What: Added native typing sounds (audio/haptic feedback) to the custom terminal keyboard accessory keys.
🎯 Why: Custom
UIInputViewaccessory buttons are completely silent by default on iOS, which breaks user expectations of tactile and audio feedback while typing.📸 Before/After: No visual change.
♿ Accessibility: Provides expected audio/haptic confirmation of key presses, which is critical non-visual feedback for all users.
PR created automatically by Jules for task 1057178079744188697 started by @emkey1