🎨 Palette: Improve button UX and accessibility in diagnostics view#1796
🎨 Palette: Improve button UX and accessibility in diagnostics view#1796emkey1 wants to merge 2 commits into
Conversation
💡 What: Wrapped `copiedReport` state toggles in `withAnimation {}` to gracefully transition the "Copy Report" button text. Added explicit `accessibilityLabel`s and `accessibilityHint`s to both the "Copy Report" and "Run Diagnostics" buttons.
🎯 Why: Transient button state changes should be visually smooth rather than abrupt text swaps. Furthermore, VoiceOver relies heavily on `accessibilityHint` to clarify the actual behavior of supplementary or dynamic buttons.
♿ Accessibility: The "Copy Report" button now dynamically reads "Copied diagnostic report" when toggled. Both buttons now have detailed `accessibilityHint`s explaining their terminal-specific behavior (e.g. "Executes the suite of diagnostic checks for the application").
Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Wrapped `copiedReport` state toggles in `withAnimation {}` to gracefully transition the "Copy Report" button text. Added explicit `accessibilityLabel`s and `accessibilityHint`s to both the "Copy Report" and "Run Diagnostics" buttons.
🎯 Why: Transient button state changes should be visually smooth rather than abrupt text swaps. Furthermore, VoiceOver relies heavily on `accessibilityHint` to clarify the actual behavior of supplementary or dynamic buttons.
♿ Accessibility: The "Copy Report" button now dynamically reads "Copied diagnostic report" when toggled. Both buttons now have detailed `accessibilityHint`s explaining their terminal-specific behavior (e.g. "Executes the suite of diagnostic checks for the application").
Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
1 participant
💡 What: Wrapped
copiedReportstate toggles inwithAnimation {}to gracefully transition the "Copy Report" button text. Added explicitaccessibilityLabels andaccessibilityHints to both the "Copy Report" and "Run Diagnostics" buttons.🎯 Why: Transient button state changes should be visually smooth rather than abrupt text swaps. Furthermore, VoiceOver relies heavily on
accessibilityHintto clarify the actual behavior of supplementary or dynamic buttons.♿ Accessibility: The "Copy Report" button now dynamically reads "Copied diagnostic report" when toggled. Both buttons now have detailed
accessibilityHints explaining their terminal-specific behavior (e.g. "Executes the suite of diagnostic checks for the application").PR created automatically by Jules for task 945418001760235151 started by @emkey1