🎨 Palette: Add haptics and a11y to settings copy action#1791
Open
emkey1 wants to merge 3 commits into
Open
Conversation
…pying tab colors 💡 What: Added `UIAccessibility.post` and `UINotificationFeedbackGenerator` to the "Copy First Tab Values" button in the Terminal Settings view. 🎯 Why: Provides essential non-visual confirmation when a silent, transient action occurs. This improves both the accessibility for VoiceOver users and the tactile feel for general users. 📸 Before/After: Visuals remain mostly the same (the "Copied!" text still appears), but it now triggers an explicit screen reader announcement and a success vibration. ♿ Accessibility: Ensures VoiceOver explicitly announces "Colors copied successfully" instead of remaining silent or repeating the button's static label. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…pying tab colors 💡 What: Added `UIAccessibility.post` and `UINotificationFeedbackGenerator` to the "Copy First Tab Values" button in the Terminal Settings view. 🎯 Why: Provides essential non-visual confirmation when a silent, transient action occurs. This improves both the accessibility for VoiceOver users and the tactile feel for general users. 📸 Before/After: Visuals remain mostly the same (the "Copied!" text still appears), but it now triggers an explicit screen reader announcement and a success vibration. ♿ Accessibility: Ensures VoiceOver explicitly announces "Colors copied successfully" instead of remaining silent or repeating the button's static label. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
…pying tab colors 💡 What: Added `UIAccessibility.post` and `UINotificationFeedbackGenerator` to the "Copy First Tab Values" button in the Terminal Settings view. 🎯 Why: Provides essential non-visual confirmation when a silent, transient action occurs. This improves both the accessibility for VoiceOver users and the tactile feel for general users. 📸 Before/After: Visuals remain mostly the same (the "Copied!" text still appears), but it now triggers an explicit screen reader announcement and a success vibration. ♿ Accessibility: Ensures VoiceOver explicitly announces "Colors copied successfully" instead of remaining silent or repeating the button's static label. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added explicit VoiceOver announcements and haptic feedback when copying terminal tab colors.
PR created automatically by Jules for task 16414105255605960127 started by @emkey1