🎨 Palette: Add missing audio feedback to custom terminal keys#1786
🎨 Palette: Add missing audio feedback to custom terminal keys#1786emkey1 wants to merge 3 commits into
Conversation
When implementing a custom `UIInputView` for keyboard accessory rows on iOS, the native keyboard clicking sounds are absent by default. This commit introduces a new `TerminalAccessoryInputView` subclass that conforms to `UIInputViewAudioFeedback` and manually triggers `UIDevice.current.playInputClick()` for all actions on the custom accessory bar. This restores the expected native typing experience when using the arrow keys, modifier toggles, and other custom terminal buttons. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
When implementing a custom `UIInputView` for keyboard accessory rows on iOS, the native keyboard clicking sounds are absent by default. This commit introduces a new `TerminalAccessoryInputView` subclass that conforms to `UIInputViewAudioFeedback` and manually triggers `UIDevice.current.playInputClick()` for all actions on the custom accessory bar. This restores the expected native typing experience when using the arrow keys, modifier toggles, and other custom terminal buttons. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
When implementing a custom `UIInputView` for keyboard accessory rows on iOS, the native keyboard clicking sounds are absent by default. This commit introduces a new `TerminalAccessoryInputView` subclass that conforms to `UIInputViewAudioFeedback` and manually triggers `UIDevice.current.playInputClick()` for all actions on the custom accessory bar. This restores the expected native typing experience when using the arrow keys, modifier toggles, and other custom terminal buttons. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
1 participant
💡 What: Adds native typing sounds (audio feedback) to the custom terminal keyboard accessory bar.
🎯 Why: Custom
UIInputViewkeyboards do not play native click sounds by default. This makes typing on the custom terminal keys (arrows, modifiers, symbols) feel "dead" compared to the native iOS keyboard.♿ Accessibility/UX: Restores the expected auditory feedback standard on iOS keyboards, confirming to users that their tap was registered without needing visual confirmation.
📖 Journaled: Added learning to
.Jules/palette.mdexplaining theUIInputViewAudioFeedbackprotocol requirement.PR created automatically by Jules for task 14988865717481076915 started by @emkey1