🎨 Palette: Add native typing sounds to custom keyboard accessory view#1782
🎨 Palette: Add native typing sounds to custom keyboard accessory view#1782emkey1 wants to merge 1 commit into
Conversation
In `TerminalInputBridge.swift` and `TerminalNativeTextView.swift`, the custom UIInputView now conforms to `UIInputViewAudioFeedback` with `enableInputClicksWhenVisible = true`. Each button action handler now invokes `UIDevice.current.playInputClick()`, restoring standard iOS typing feedback that is normally missing from custom accessory bars. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added native iOS typing sounds to the custom keyboard accessory keys (like arrows, esc, tab, toggles) in the terminal view.
🎯 Why: Custom
UIInputViewaccessory rows do not inherit standard keyboard clicks by default. This makes the keys feel "dead" or unresponsive compared to typing on the regular iOS system keyboard beneath them.♿ Accessibility: Provides auditory confirmation that a custom accessory key was successfully pressed, benefiting both sighted and visually impaired users.
📸 Before/After: No visual changes, auditory enhancement only.
PR created automatically by Jules for task 13434137452636313243 started by @emkey1