🎨 Palette: Improve AppDiagnosticsView UX and Accessibility#1780
Conversation
💡 What: - Wrapped `copiedReport` state changes in `withAnimation` blocks for smooth transient text transitions. - Added dynamic `accessibilityLabel` to the "Copy Report" button based on its transient state. - Added `accessibilityHint`s to both the "Copy Report" and "Run Diagnostics" buttons. 🎯 Why: - Transient visual states appearing and disappearing abruptly can feel unpolished. `withAnimation` provides a graceful transition. - Screen reader users were previously missing context on what the icon-only buttons do, and state changes weren't being announced, reducing the interface's accessibility. ♿ Accessibility: - Added context via VoiceOver hints. - Ensured state changes on the copy button are dynamically represented in VoiceOver labels. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: - Wrapped `copiedReport` state changes in `withAnimation` blocks for smooth transient text transitions. - Added dynamic `accessibilityLabel` to the "Copy Report" button based on its transient state. - Added `accessibilityHint`s to both the "Copy Report" and "Run Diagnostics" buttons. 🎯 Why: - Transient visual states appearing and disappearing abruptly can feel unpolished. `withAnimation` provides a graceful transition. - Screen reader users were previously missing context on what the icon-only buttons do, and state changes weren't being announced, reducing the interface's accessibility. ♿ Accessibility: - Added context via VoiceOver hints. - Ensured state changes on the copy button are dynamically represented in VoiceOver labels. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
💡 What:
copiedReportstate changes inwithAnimationblocks for smooth transient text transitions.accessibilityLabelto the "Copy Report" button based on its transient state.accessibilityHints to both the "Copy Report" and "Run Diagnostics" buttons.🎯 Why:
withAnimationprovides a graceful transition.♿ Accessibility:
PR created automatically by Jules for task 1884646995970992144 started by @emkey1