add commonly used file extensions#140
Open
st-h wants to merge 1 commit into
Open
Conversation
from emberjs/rfcs#648 this PR adds default support for file suffixes: `svg`, `webp`, `mp4`, `webmanifest` and `json`
|
Good idea! No biggie, but is 'webmanifest' common enough to warrant default inclusion? I'd never heard of it and browser support isn't very good (not supported by Safari, for example). Still labeled as "experimental" by MDN. |
Author
|
@sandstrom sorry about not getting back to this any earlier. Support isn't that bad per se: https://caniuse.com/?search=manifest Additionally it seems to be better to support more commonly used items than less, since this also configures which file types to use the prepend option for. Any missing file types will cause loading of these resources to fail. Otherwise: is there any issue which is preventing us from merging? I had opened an RFC previously and there did not seem to be any objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from emberjs/rfcs#648 this PR adds default support for file suffixes:
svg,webp,mp4,webmanifestandjson