Use pdo quote for explain string replacment#54
Closed
jaicarlton wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A claude security scan that highlighted that single quotation marks in $value break out of string literals. A legitimate use case is
O'Brien.For this solution, using
$this->getConnection()->quote($value)as it will handle the correct escaping per db.This issue is that it will change the behaviour for null values passed in.
quote(null)Before
"'$value'"with$value = nullwould result in''(an empty single quotes string).With
quote(null)it will return the string'NULL'(NULL surrounded by single quotes) on Postgres and on the rest of the drives it will return''.To facilitate null mapping instead, a null guard is being used.
Added unit tests testing fix.
This is breaking change.