Escape column input in table sum#53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a claude security scan it highlighted that
sum($column)inlib/PicoDb/Table.phpwasn't using$this->db->escapeIdentifier()for$columninput parameter.Everywhere else there is a
$columninput parameter is used is escaped.From commit logs it looks like it existed before and was removed in commit
daf9b7404cad3bf559f955193c424580c7799d30- "Add notLike, between and not between. #15".This seems like it was unintentional regression.
Unit test added to test fix.
Security update and potential breaking change.