Wagtail 6.x - #51
Open
katdom13 wants to merge 0 commit into
Open
Conversation
katdom13
commented
Jun 14, 2024
katdom13
commented
- Replace deprecated svg icon font with new icon.
- Make compatible with Wagtail 6.x
- Drop support for Wagtail versions < 5.2
- Drop support for Django 3.2
Author
|
@elton2048 , |
elton2048
reviewed
Jun 24, 2024
elton2048
left a comment
elton2048
left a comment
Owner
There was a problem hiding this comment.
🙏 Thanks for the commit! Since I am not active in using the library so I will just review to see if the code looks good.
Please helps to update the code for better doc and style, and then I will approve the PR.
| success: function(data, textStatus, xhr) { | ||
| addMessage('success', '"' + movedObjectTitle + '" has been moved successfully.'); | ||
| const text = '"' + movedObjectTitle + '" has been moved successfully.'; | ||
| const event = new CustomEvent('w-messages:add', { detail: { clear: true, text, type: 'success' } }); |
| error: function(data, textStatus, xhr) { | ||
| addMessage('error', '"' + movedObjectTitle + '" could not be moved.'); | ||
| const text = '"' + movedObjectTitle + '" could not be moved.'; | ||
| const event = new CustomEvent('w-messages:add', { detail: { clear: true, text, type: 'error' } }); |
| Install the package | ||
| ``` | ||
| pip install wagtail-orderable | ||
| pip install wagtail-modeladmin |
Owner
There was a problem hiding this comment.
Suggestion: I would say to install this before the package (i.e. put this statement before) as this is a dependency for this package, though it might be not so important as they will be installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.