Skip to content

Finish the validation #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qoshi wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Finish the validation #82

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f99e1a7
Add enumSchema validate
Aug 15, 2016
86a45f5
Enhance implement of enumschema validation
Aug 18, 2016
8b3b71a
Modify enum validation implement
Aug 19, 2016
570c14c
Enhance the implement of valid for enum
Aug 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,25 @@ func (s *EnumSchema) Prop(key string) (interface{}, bool) {
}

// Validate checks whether the given value is writeable to this schema.
func (*EnumSchema) Validate(v reflect.Value) bool {
//TODO implement
func (s *EnumSchema) Validate(v reflect.Value) bool {
//WARNING cuz only ptr could
if v.Kind() != reflect.Ptr {
if v.CanAddr() == false {
return false
}
v = v.Addr()
}
ret := v.MethodByName("GetIndex").Call([]reflect.Value{})
if len(ret) == 0 {
return false
}
index := ret[0].Interface().(int32)
if index < 0 {
return false
}
if index >= int32(len(s.Symbols)) {
return false
}
return true
}

Expand Down