Fix invalid JSON in receipt print response#82
Open
Igglybuff wants to merge 1 commit into
Open
Conversation
success_response and error_response were building JSON via string interpolation. A title containing any characters (particularly the wrapping quotes added by the format string) produced malformed JSON that browsers couldn't parse. Switch both functions to use axum::Json with serde-derived structs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
success_responseanderror_responsefunctions were building JSON via string interpolation. When a title was provided, the format string wrapped it in literal"characters which were then embedded directly into the JSON string value, producing invalid JSON:The no-title branch happened to produce valid JSON, so the bug only manifested when a title was actually supplied.
Fix: switch both functions to
axum::Jsonwith serde-derived structs so serialization is always correct regardless of input.🤖 Generated with Claude Code