Print repo name in connection pool errors#334
Merged
josevalim merged 5 commits intoOct 30, 2025
Merged
Conversation
Member
|
Hi @guisehn I would prefer to not depend on repo, because it is really not a db_connection configuration or concern. Looking at the connection pool, maybe you can rely on $ancestors? Something like this: List.first(Process.get(:"$ancestors, []))Or perhaps this: Enum.find(Process.get(:"$ancestors, []), &is_atom/1)This would also simplify the PR as you won't need to pass all state around. Thanks! |
Contributor
Author
|
@josevalim nice trick! Touching all the function signatures was really giving me the creeps. :) Implemented on 343dec5 |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the pool name to connection pool errors, helping to find the database with problems when an application uses multiple repos:
Solves #333