Skip to content

Use process labels#330

Merged
josevalim merged 8 commits into
elixir-ecto:masterfrom
nathanl:use_process_labels
Sep 9, 2025
Merged

Use process labels#330
josevalim merged 8 commits into
elixir-ecto:masterfrom
nathanl:use_process_labels

Conversation

@nathanl

@nathanl nathanl commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This probably needs tweaking, but I periodically see people asking (and have wondered myself) how to figure out which test in a suite is responsible for something like

18:09:26.437 [error] Postgrex.Protocol (#PID<0.413.0>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.2759.0> exited

This is an attempt to make our systems and their errors easier to understand.

Comment thread lib/db_connection/util.ex Outdated
Comment thread lib/db_connection/util.ex Outdated
nathanl and others added 2 commits September 9, 2025 10:14
Co-authored-by: José Valim <jose.valim@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
Comment thread lib/db_connection/util.ex Outdated
@josevalim

Copy link
Copy Markdown
Member

Thank you for the pull request. I believe this is a great addition. I have added some comments, so we also look up the name.

Co-authored-by: José Valim <jose.valim@gmail.com>
@nathanl

nathanl commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

@josevalim Awesome, thank you for the improvements!

@nathanl

This comment was marked as resolved.

Comment thread lib/db_connection/util.ex
Comment thread lib/db_connection/util.ex Outdated
@josevalim josevalim merged commit 2db46fb into elixir-ecto:master Sep 9, 2025
2 checks passed
@josevalim

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

@josevalim

Copy link
Copy Markdown
Member

Btw @nathanl , would you like to send a PR to Elixir that automatically adds set_label({CaseName, test_name}) to Elixir tests?

@nathanl

nathanl commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

@josevalim very much yes, I was going to try that next 😄 ❤️

@nathanl nathanl deleted the use_process_labels branch September 9, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants