Skip to content

Honor de.sorunome.msc2409.push_ephemeral flag in appservice handler #19928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weebl2000 wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −1
Open

Honor de.sorunome.msc2409.push_ephemeral flag in appservice handler #19928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/19927.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a regression where application services that opted into ephemeral events using the legacy `de.sorunome.msc2409.push_ephemeral` registration flag stopped receiving ephemeral events (including to-device messages used for encryption). Introduced in v1.156.0.
5 changes: 4 additions & 1 deletion synapse/handlers/appservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,10 @@ def notify_interested_services_ephemeral(
StreamKeyType.PRESENCE,
StreamKeyType.TO_DEVICE,
)
and service.supports_ephemeral
# Honour both the stable `receive_ephemeral` registration flag and the
# legacy `de.sorunome.msc2409.push_ephemeral` one, matching the
# transaction body built in `ApplicationServiceApi.push_bulk`.
and (service.supports_ephemeral or service.supports_unstable_ephemeral)
)
or (
stream_key == StreamKeyType.DEVICE_LIST
Expand Down