Fix bug where sliding sync ignored room_id_to_include option#18535
Merged
Conversation
This was correctly handled for the "fallback" case where the background updates hadn't finished.
MadLittleMods
requested changes
Jun 10, 2025
Co-authored-by: Eric Eastwood <erice@element.io>
So that we don't include them in the list ops.
MadLittleMods
requested changes
Jun 11, 2025
Co-authored-by: Eric Eastwood <erice@element.io>
erikjohnston
force-pushed
the
erikj/ss_exclude_rooms_from_sync
branch
from
8d34210 to
04d2750
Compare
MadLittleMods
approved these changes
Jun 12, 2025
erikjohnston
force-pushed
the
erikj/ss_exclude_rooms_from_sync
branch
3 times, most recently
from
3d610f6 to
0f46209
Compare
erikjohnston
force-pushed
the
erikj/ss_exclude_rooms_from_sync
branch
from
0f46209 to
e9baf1f
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was correctly handled for the "fallback" case where the background updates hadn't finished