Sliding sync: Ignore invites from ignored users#17729
Merged
MadLittleMods merged 6 commits intoSep 18, 2024
Merged
Conversation
MadLittleMods
commented
Sep 18, 2024
| if change is None: | ||
| # Remove rooms that the user joined after the `to_token` | ||
| room_membership_for_user_map.pop(room_id) | ||
| room_membership_for_user_map.pop(room_id, None) |
Contributor
Author
There was a problem hiding this comment.
Unrelated but added a default to the .pop(...) so we don't run into a KeyError if the room_id is already removed from the dict.
MadLittleMods
commented
Sep 18, 2024
Comment on lines
+230
to
+231
| # TODO: It would be nice to avoid these copies | ||
| room_membership_for_user_map = dict(room_membership_for_user_map) |
Contributor
Author
There was a problem hiding this comment.
Another reason to potentially add SoftDeleteChainMap (context #17725 (comment))
Would tackle in a separate PR though.
devonh
requested changes
Sep 18, 2024
devonh
left a comment
devonh
left a comment
Member
There was a problem hiding this comment.
Just a small change. Otherwise things look good.
devonh
approved these changes
Sep 18, 2024
MadLittleMods
deleted the
madlittlemods/ignore-invites-from-ignored-users
branch
Contributor
Author
|
Thanks for the review @devonh 🐻❄️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore invites from ignored users (
m.ignored_user_listin account data)Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)