Fix sliding sync on workers#17649
Merged
Merged
Conversation
anoadragon453
approved these changes
Sep 3, 2024
anoadragon453
left a comment
anoadragon453
left a comment
Member
There was a problem hiding this comment.
So the problem was that this background update could only run on the main process, not the background worker?
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
| _BackgroundUpdates.SLIDING_SYNC_MEMBERSHIP_SNAPSHOTS_BG_UPDATE, | ||
| ) | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
What was the problem on workers in the first place?
How does this fix the problem?
Member
Author
There was a problem hiding this comment.
Not all of the storage classes are used on workers, i.e. there are actually two mixins of data stores: one for workers and one for the master. This store isn't in the worker data store.
Ideally we'd merge the two datastores and add asserts to the functions that can't be run on workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broke in #17630