Media Preview content scanning#5851
Open
Velin92 wants to merge 2 commits into
Open
Conversation
…sture for the error and loading states
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5851 +/- ##
===========================================
- Coverage 74.28% 74.26% -0.02%
===========================================
Files 819 820 +1
Lines 57407 57494 +87
===========================================
+ Hits 42643 42700 +57
- Misses 14764 14794 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for scanning and presenting the result of the scan for medias also in the media preview carousel. I also added a way for the error state to also be swiped across the screen so that it feels natural when swiping between items that belong to QL, if one of the items has an unsafe error. (Otherwise it's hard to tell that the swipe is actually happening)