Scanning states for the media events timeline screen#5847
Merged
Velin92 merged 2 commits intoJul 8, 2026
Conversation
49be656 to
b98f78c
Compare
pixlwave
approved these changes
Jul 7, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5847 +/- ##
===========================================
+ Coverage 74.23% 74.28% +0.04%
===========================================
Files 818 819 +1
Lines 57284 57407 +123
===========================================
+ Hits 42525 42642 +117
- Misses 14759 14765 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a scanning and a failure state for the elements of the MediaEventsTimeline, precisely for images and videos (since files audio and voice messages, will reuse the existing implementation). Here however it needs to be pointed out that for files, audio, images and videos in these views, we are for now allowing the tap actions, and the reason is that this opens up a scrollable preview of the elements, which in turn will display an error state when an unsafe file is displayed (so the download prevention is still happening, and we have an extra error state view in the preview), so that it's still possible to swipe between the elements in order, but prevent the download of such elements. However this last bit of the feature will be implemented in the next PR. Will however double check with design if we intend to prevent the tap altogether or not