Skip to content

Scanning states for the media events timeline screen#5847

Merged
Velin92 merged 2 commits into
developfrom
mauroromito/media_events_timeline_screen_scanning
Jul 8, 2026
Merged

Scanning states for the media events timeline screen#5847
Velin92 merged 2 commits into
developfrom
mauroromito/media_events_timeline_screen_scanning

Conversation

@Velin92

@Velin92 Velin92 commented Jul 7, 2026

Copy link
Copy Markdown
Member

This PR adds a scanning and a failure state for the elements of the MediaEventsTimeline, precisely for images and videos (since files audio and voice messages, will reuse the existing implementation). Here however it needs to be pointed out that for files, audio, images and videos in these views, we are for now allowing the tap actions, and the reason is that this opens up a scrollable preview of the elements, which in turn will display an error state when an unsafe file is displayed (so the download prevention is still happening, and we have an extra error state view in the preview), so that it's still possible to swipe between the elements in order, but prevent the download of such elements. However this last bit of the feature will be implemented in the next PR. Will however double check with design if we intend to prevent the tap altogether or not

@Velin92 Velin92 force-pushed the mauroromito/media_events_timeline_screen_scanning branch from 49be656 to b98f78c Compare July 7, 2026 15:58
@Velin92 Velin92 marked this pull request as ready for review July 7, 2026 15:58
@Velin92 Velin92 requested a review from a team as a code owner July 7, 2026 15:58
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 7, 2026 15:58
@Velin92 Velin92 added the pr-feature for a new feature label Jul 7, 2026

@pixlwave pixlwave left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.94595% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.28%. Comparing base (9e1d95d) to head (b943344).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...w/TimelineViews/VideoMediaEventsTimelineView.swift 78.57% 3 Missing ⚠️
...imelineScreen/View/MediaEventsTimelineScreen.swift 96.77% 2 Missing ⚠️
...r/TestablePreview/TestablePreviewsDictionary.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5847      +/-   ##
===========================================
+ Coverage    74.23%   74.28%   +0.04%     
===========================================
  Files          818      819       +1     
  Lines        57284    57407     +123     
===========================================
+ Hits         42525    42642     +117     
- Misses       14759    14765       +6     
Flag Coverage Δ
unittests 64.52% <95.94%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 5fd4551 into develop Jul 8, 2026
5 of 8 checks passed
@Velin92 Velin92 deleted the mauroromito/media_events_timeline_screen_scanning branch July 8, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants